Open
Conversation
jrasm91
force-pushed
the
refactor/auth-manager
branch
3 times, most recently
from
da4242d to
3b50d87
Compare
jrasm91
force-pushed
the
refactor/auth-manager
branch
from
3b50d87 to
e0f8acb
Compare
danieldietzler
approved these changes
Apr 9, 2026
Comment on lines
+78
to
+84
| setUser(user: UserAdminResponseDto) { | ||
| this.#user = user; | ||
| } | ||
|
|
||
| setPreferences(preferences: UserPreferencesResponseDto) { | ||
| this.#preferences = preferences; | ||
| } |
Member
There was a problem hiding this comment.
I would personally prefer setters (it feels more natural given we already have the getters, and it also seems more ergonomic here) but that's 100% personal preference
Member
Author
There was a problem hiding this comment.
I think I want to potentially migrate to events instead and this makes it easier to isolate/track imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move user and preferences stores to auth manager