PR: ESM Migration, Vite 8 Upgrade, and Dependency Overhaul by onemen · Pull Request #1649 · raineorshine/npm-check-updates

onemen · 2026-04-05T08:41:20Z

Description

This PR transitions the project to a native ESM architecture while maintaining dual-build support (ESM/CJS) via Vite. It includes a major overhaul of the development toolchain, upgrading core dependencies to their 2026 standards, and significantly modernizing the internal logic.

Key Changes

Module System & Interop:
- Converted the project to Pure ESM.
- Replaced all dynamic imports with static ESM imports.
- Configured Vite to build exports for both CLI and index in ESM and CJS formats.
- Testing: Updated Mocha to use tsx for module loading (e.g., via --import tsx), ensuring seamless TypeScript support in an ESM context.
Major Upgrades:
- Vite v8: Transitioned to the new Rust-based Rolldown bundler (10-30x faster builds).
- TypeScript v6.0: Adopted the latest type-system features and performance improvements.
Tooling & CI/CD:
- Switched to ts-json-schema-generator and implemented in-process Prettier formatting.
- Moved build options directly into vite build and replaced vite-node with tsx.
- Replaced strip-ansi with the Node.js built-in node:util/stripVTControlCharacters.
- Enhanced quality gates: Added typecheck to pre-push hooks and the linting action.

⚠️ Breaking Changes

This is a major breaking change and requires a major version bump:

Node.js & npm Requirements:
- Node.js: Now requires ^20.19.0 || ^22.12.0 || >=24.0.0. This is strictly required by Vite 8 for native require(esm) support and the Rolldown engine.
- npm: Minimum version increased to >=10.0.0.
Pure ESM Dependencies: Several key dependencies have been updated to their latest Pure ESM versions, dropping support for older CJS environments:

Package Old Version New Version

camelcase ^6.3.0 ^9.0.0

chai ^4.3.10 ^6.2.2

chai-as-promised ^7.1.2 ^8.0.2

find-up 5.0.0 8.0.0

p-map ^4.0.0 ^7.0.4

untildify ^4.0.0 ^6.0.0

Note on Mocha + `tsx`

Since the project is now ESM, we are using tsx to handle the TypeScript transformation during test execution. If you are running tests manually, ensure you are using the new command structure:
mocha --node-option import=tsx 'test/**/*.test.ts' (or your defined script in package.json).

- update vite config - use lodash-es instead of lodash - use memoize instead of old fast-memoize

ES Modules cannot be stubbed To allow stubbing of npm functions in tests, we export the functions that need to be stubbed as properties of an object (npmApi, pnpmApi, yarnApi) that can be imported and stubbed in tests without affecting the rest of the module. (+1 squashed commits) use tsx instead of ts-node with mocha

…rning: `url.parse()` in node 24

…ch is a built-in module in node

- Update major devDependencies to latest. - Remove `legacy-peer-deps=true` to ensure strict, modern resolution. - Implement surgical `overrides` to resolve peer dependency conflicts across the ESLint, Microsoft, and Verdaccio toolchains. - Fix hoisting issue where `ajv/dist/core` was missing in nested node_modules under Node 25.

- Remove legacy __dirname in favor of getDirname(import.meta.url). - Enable Mocha --exit to ensure clean termination on Node 25. - Clean up listener guards and diagnostic hooks. - Successfully verified 530+ tests across modern Node environments.

update vite config remove unused nodeExternals, we see ssr.noExternal=true so we don't want to exclude node modules from the bundle

update export use tsx instead of vite-node

…ation warning: `url.parse()` in node 24" The issue was fixed in parse-github-url v1.0.4 This reverts commit 02e99e4.

- Replace custom 'test/bun-install.sh' with 'oven-sh/setup-bun@v2' action. - Add 'check-environment' before-hook to provide helpful install links. - Fix TypeScript 'Property does not exist' errors via namespace imports. - Resolve ESLint 'Parsing error' in VS Code using tsconfigRootDir. - Update test logic to use node:child_process for better cross-platform compatibility.

Update resolveConfig to use a file path instead of a directory to correctly load .prettierrc.json in ESM. Re-generate src/types/RunOptions.json with correct project formatting. Fixes pre-push hook failures caused by formatting mismatches.

Update mocha configuration to ignore test/bun/* during unit tests. This prevents CI failures in environments where Bun is not yet installed.

Build: Update Vite config to use explicit output arrays for es and cjs formats. Build: Force .cjs extensions for CommonJS chunks to prevent Node.js from parsing them as ESM in "type: module" projects. E2E: Fix TypeError in ESM E2E tests by aligning namespace imports with the new build output. E2E: Add Windows fallback for lsof in test/e2e.sh using netstat and taskkill to allow local registry cleanup on Windows 11.

onemen · 2026-04-05T16:22:25Z

@raineorshine

let me know if there are any documentation that need update

- Update CONTRIBUTING.md with source map documentation - Add Development section with Node.js requirements and test instructions - Update Executable Stack Trace section to reflect generated source maps - Add v21.0.0 entry to CHANGELOG.md documenting breaking changes - Add Requirements section to README.md with Node.js and npm version constraints

onemen · 2026-04-05T18:45:04Z

@raineorshine

check the updates in ab34e63

raineorshine

Thanks so much!

raineorshine · 2026-04-07T00:12:51Z

src/package-managers/npm.ts

+  {
+    /**
+     * Because this function depends on both the first object AND the options object,
+     * we must provide a cacheKey. Modern memoize provides both args in an array.
+     */
+    cacheKey: ([configs, options]) => {
+      return JSON.stringify([configs, options.packageFile, options.cwd, options.registry, options.timeout])
+    },
+  },


Explicit cache keys are going to be fragile and hard to maintain. If the function changes to use additional options in the future, there is no compile-time check to ensure these cache keys stay in sync, resulting in hard-to-catch caching bugs.

Instead, we should use a default serializer like fast-memoize did. Perhaps JSON.stringify would suffice?

You also use JSON.stringify in fetchUpgradedPackumentMemo
do you want to modify both

by Perhaps JSON.stringify would suffice did you mean JSON.stringify([configs, options])

Just cacheKey: JSON.stringify I believe. You can use this same pattern in all the memoize calls to preserve the existing behavior and avoid explicitly listing the inputs.

test/helpers/chaiSetup.ts

test/cooldown.test.ts

.ncurc.cjs

README.md

CHANGELOG.md

package.json

onemen added 19 commits April 1, 2026 21:09

upgrade to typescript v6.0

59c4c6a

Convert to ESM package

bfc6728

- update vite config - use lodash-es instead of lodash - use memoize instead of old fast-memoize

fix missing import types

2a3a65e

use hosted-git-info instead of parse-github-url to fix deprecation wa…

02e99e4

…rning: `url.parse()` in node 24

fix doctor.test.ts

87ae740

replace strip-ansi with stripVTControlCharacters from node:util, whi…

2ff432f

…ch is a built-in module in node

replace dynamic imports with static ESM imports

6b5168a

update markdownlint config to json

b466904

fix lodash vulnerabilities

0a873b9

upgrade to vite 8

9487df7

update vite config remove unused nodeExternals, we see ssr.noExternal=true so we don't want to exclude node modules from the bundle

add typecheck to pre-push and lint action

e97b008

switch to ts-json-schema-generator and in-process Prettier formatting

b15180c

move build-options into vite build

1139bc4

update export use tsx instead of vite-node

Merge branch 'main' into pr/esm-v21.0.0

e577c23

Revert "use hosted-git-info instead of parse-github-url to fix deprec…

65f87ec

…ation warning: `url.parse()` in node 24" The issue was fixed in parse-github-url v1.0.4 This reverts commit 02e99e4.

remove redundant overrides

bd3a73d

onemen marked this pull request as draft April 5, 2026 08:44

onemen added 4 commits April 5, 2026 15:50

test: exclude bun tests from unit test suite

32d160f

Update mocha configuration to ignore test/bun/* during unit tests. This prevents CI failures in environments where Bun is not yet installed.

onemen marked this pull request as ready for review April 5, 2026 15:52

raineorshine requested changes Apr 7, 2026

View reviewed changes

raineorshine mentioned this pull request Apr 7, 2026

fix: vite build warning #1654

Open

onemen mentioned this pull request Apr 9, 2026

fix: e2e.sh on windows #1657

Open

onemen added 5 commits April 9, 2026 14:51

docs: update readme and changelog for ESM

b58413f

inlining dirname(fileURLToPath(import.meta.url))

a3ef542

update dependencies

370a65c

fix review commnets

1daa3ad

fix markdown linter errors

0da2c26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: ESM Migration, Vite 8 Upgrade, and Dependency Overhaul#1649

PR: ESM Migration, Vite 8 Upgrade, and Dependency Overhaul#1649
onemen wants to merge 29 commits intoraineorshine:mainfrom
onemen:pr/esm-v21.0.0

onemen commented Apr 5, 2026 •

edited

Loading

Uh oh!

onemen commented Apr 5, 2026

Uh oh!

onemen commented Apr 5, 2026

Uh oh!

raineorshine left a comment

Uh oh!

raineorshine Apr 7, 2026

Uh oh!

onemen Apr 9, 2026

Uh oh!

raineorshine Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Package	Old Version	New Version
`camelcase`	`^6.3.0`	`^9.0.0`
`chai`	`^4.3.10`	`^6.2.2`
`chai-as-promised`	`^7.1.2`	`^8.0.2`
`find-up`	`5.0.0`	`8.0.0`
`p-map`	`^4.0.0`	`^7.0.4`
`untildify`	`^4.0.0`	`^6.0.0`

Conversation

onemen commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Key Changes

⚠️ Breaking Changes

Note on Mocha + tsx

Uh oh!

onemen commented Apr 5, 2026

Uh oh!

onemen commented Apr 5, 2026

Uh oh!

raineorshine left a comment

Choose a reason for hiding this comment

Uh oh!

raineorshine Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

onemen Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

raineorshine Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

onemen commented Apr 5, 2026 •

edited

Loading

Note on Mocha + `tsx`